Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty menu on home page on mobile viewport #2066

Open
sniok opened this issue Jun 20, 2024 · 6 comments · May be fixed by #2603
Open

Empty menu on home page on mobile viewport #2066

sniok opened this issue Jun 20, 2024 · 6 comments · May be fixed by #2603
Assignees
@skoeva
Labels
bug Something isn't working frontend Issues related to the frontend mobile Issues affecting small screens regression Bugs for things that used to work in previous releases.

Comments

@sniok
Copy link
Contributor

sniok commented Jun 20, 2024

image

the three dot menu on the right opens an empty menu. on desktop it's not visible
@sniok sniok added bug Something isn't working frontend Issues related to the frontend mobile Issues affecting small screens labels Jun 20, 2024
@sniok sniok mentioned this issue Jun 20, 2024
Merged
4 tasks
@illume illume added the regression Bugs for things that used to work in previous releases. label Jul 8, 2024
@skoeva
Copy link
Contributor

skoeva commented Jul 23, 2024

Is this issue the same as #1719?

@illume
Copy link
Collaborator

illume commented Jul 25, 2024

Yeah, this was the same issue and it's fixed now. AFAIK

@illume illume closed this as completed Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Queued to Done in Release Plan / Roadmap Jul 25, 2024
@sniok
Copy link
Contributor Author

sniok commented Nov 20, 2024

This is still an issue, the ticket mentioned above is unrelated. The menu that's not working is in top right

image

@sniok sniok reopened this Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Release Plan / Roadmap Nov 20, 2024
@skoeva
Copy link
Contributor

skoeva commented Nov 20, 2024 •
edited
Loading

@sniok How did you reproduce the issue?

This is what I see on my end (this could probably be fixed otherwise):

image

@sniok
Copy link
Contributor Author

sniok commented Nov 20, 2024

On the home view it's empty. On other views (like on your screenshot) if you click not directly on the icon it will do a ripple effect but nothing happens

@skoeva
Copy link
Contributor

skoeva commented Nov 20, 2024

Ah I see. Will look into this

skoeva added a commit that referenced this issue Nov 22, 2024
@skoeva
frontend: Improve top bar menu on mobile
1ea6be5 
This change addresses issues with the top bar on mobile devices, both in
the home view and in-cluster.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 22, 2024
@skoeva
frontend: Improve top bar menu on mobile
35eb804 
This change addresses issues with the top bar on mobile devices, both in
the home view and in-cluster.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Nov 22, 2024 that will close this issue
Open
2 tasks
@skoeva skoeva linked a pull request Nov 22, 2024 that will close this issue
frontend: TopBar: Hide menu on mobile when empty #2603
Open
2 tasks
skoeva added a commit that referenced this issue Nov 25, 2024
@skoeva
frontend: Improve top bar menu on mobile
f0d48a0 
This change addresses issues with the top bar on mobile devices, both in
the home view and in-cluster.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 27, 2024
@skoeva
frontend: Improve top bar menu on mobile
527a1dd 
This change addresses issues with the top bar on mobile devices, both in
the home view and in-cluster.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Dec 2, 2024
@skoeva
frontend: Improve top bar menu on mobile
54130f9 
This change addresses issues with the top bar on mobile devices, both in
the home view and in-cluster.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Dec 2, 2024
@skoeva
frontend: Improve top bar menu on mobile
e02c9c5 
This change addresses issues with the top bar on mobile devices, both in
the home view and in-cluster.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Dec 16, 2024
@skoeva
frontend: TopBar: Hide menu on mobile when empty
498b696 
This change hides the top bar menu on mobile when there are no actions
to display.

Fixes: #2066

Signed-off-by: Evangelos Skopelitis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
bug Something isn't working frontend Issues related to the frontend mobile Issues affecting small screens regression Bugs for things that used to work in previous releases.
Projects
Release Plan / Roadmap
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: TopBar: Hide menu on mobile when empty headlamp-k8s/headlamp
3 participants
@illume @sniok @skoeva