From bf635f78d118446c8146a514f8a2685beed8a0d1 Mon Sep 17 00:00:00 2001
From: niqdev <niqdev@users.noreply.github.com>
Date: Sun, 8 Oct 2023 22:30:54 +0100
Subject: [PATCH] update task kube events

---
 README.md                            | 13 +++++++++----
 pkg/box/docker/events.go             | 16 ----------------
 pkg/client/kubernetes/client.go      |  2 +-
 pkg/client/kubernetes/client_test.go |  2 +-
 pkg/task/docker/docker.go            | 16 +++++++++-------
 pkg/task/docker/events.go            |  4 ++++
 pkg/task/kubernetes/events.go        | 28 ++++++++++++++++++++++++++++
 pkg/task/kubernetes/kubernetes.go    | 20 ++++++++++++++------
 8 files changed, 66 insertions(+), 35 deletions(-)

diff --git a/README.md b/README.md
index 3c294c8..945a263 100644
--- a/README.md
+++ b/README.md
@@ -230,7 +230,7 @@ provider:
 
 ### Cloud
 
-Access to the platform is in ***preview*** and limited. If you are interested, please leave a comment or a :thumbsup: to this [issue](https://github.com/hckops/hckctl/issues/104) and we'll reach out with more details
+Access to the platform is limited and in ***preview***. If you are interested, please leave a comment or a :thumbsup: to this [issue](https://github.com/hckops/hckctl/issues/104) and we'll reach out with more details
 ```bash
 provider:
   cloud:
@@ -275,8 +275,10 @@ tail -F ${HOME}/.local/state/hck/log/hckctl-*.log
 
 <!--
 
-* rename `template` to catalog? or alias?
-* cmd aliases e.g. start/up/create
+* task kube log file
+* task kube vpn
+* task kube shareDir ? copy dir?
+* task kube interrupt
 * replace task/htb example with thm
 * verify/support kube config relative path
 * update cloud
@@ -284,8 +286,9 @@ tail -F ${HOME}/.local/state/hck/log/hckctl-*.log
 
 TODO
 * priority
-    - add task providers: kube and cloud
     - add box kube --network-vpn
+    - add box kube shareDir
+    - add task cloud
     - debug `htb-postman`
     - lab inputs
     - add flow example
@@ -313,6 +316,8 @@ TODO
         * https://houdini.secsi.io
     - flaky tests (?)
         * kubernetes_test.go:TestNewResources
+    - rename `template` to catalog? or alias?
+    - cmd aliases e.g. start/up/create
 * cli
     - autocomplete commands and values
         * e.g. `box connect <list of boxes>` with `ValidArgsFunction`
diff --git a/pkg/box/docker/events.go b/pkg/box/docker/events.go
index 8c47925..842051e 100644
--- a/pkg/box/docker/events.go
+++ b/pkg/box/docker/events.go
@@ -24,26 +24,10 @@ func (e *dockerBoxEvent) String() string {
 	return e.value
 }
 
-func newImagePullDockerEvent(imageName string) *dockerBoxEvent {
-	return &dockerBoxEvent{kind: event.LogInfo, value: fmt.Sprintf("image pull: imageName=%s", imageName)}
-}
-
 func newImagePullDockerLoaderEvent(imageName string) *dockerBoxEvent {
 	return &dockerBoxEvent{kind: event.LoaderUpdate, value: fmt.Sprintf("pulling image %s", imageName)}
 }
 
-func newImagePullIgnoreDockerEvent(imageName string) *dockerBoxEvent {
-	return &dockerBoxEvent{kind: event.LogWarning, value: fmt.Sprintf("image pull ignored: imageName=%s", imageName)}
-}
-
-func newImageRemoveDockerEvent(imageId string) *dockerBoxEvent {
-	return &dockerBoxEvent{kind: event.LogInfo, value: fmt.Sprintf("image remove: imageId=%s", imageId)}
-}
-
-func newImageRemoveIgnoreDockerEvent(imageId string, err error) *dockerBoxEvent {
-	return &dockerBoxEvent{kind: event.LogWarning, value: fmt.Sprintf("image remove ignored: imageId=%s error=%v", imageId, err)}
-}
-
 func newNetworkUpsertDockerEvent(networkName string, networkId string) *dockerBoxEvent {
 	return &dockerBoxEvent{kind: event.LogInfo, value: fmt.Sprintf("network upsert: networkName=%s networkId=%s", networkName, networkId)}
 }
diff --git a/pkg/client/kubernetes/client.go b/pkg/client/kubernetes/client.go
index 52cbcbb..7c536a8 100644
--- a/pkg/client/kubernetes/client.go
+++ b/pkg/client/kubernetes/client.go
@@ -348,7 +348,7 @@ func (client *KubeClient) podDescribe(namespace string, listOptions metav1.ListO
 
 func newPodInfo(namespace string, pods *corev1.PodList) (*PodInfo, error) {
 	if len(pods.Items) != SingleReplica {
-		return nil, fmt.Errorf("found %d pods, expected only 1 pod for deployment: namespace=%s", len(pods.Items), namespace)
+		return nil, fmt.Errorf("found %d pods, expected only 1 pod: namespace=%s", len(pods.Items), namespace)
 	}
 
 	podItem := pods.Items[0]
diff --git a/pkg/client/kubernetes/client_test.go b/pkg/client/kubernetes/client_test.go
index 9f39a41..dc00f17 100644
--- a/pkg/client/kubernetes/client_test.go
+++ b/pkg/client/kubernetes/client_test.go
@@ -168,7 +168,7 @@ func TestNewPodInfoErrorReplica(t *testing.T) {
 	}
 	result, err := newPodInfo("myPodNamespace", pods)
 
-	assert.EqualError(t, err, "found 2 pods, expected only 1 pod for deployment: namespace=myPodNamespace")
+	assert.EqualError(t, err, "found 2 pods, expected only 1 pod: namespace=myPodNamespace")
 	assert.Nil(t, result)
 }
 
diff --git a/pkg/task/docker/docker.go b/pkg/task/docker/docker.go
index e77dc32..0e9bd73 100644
--- a/pkg/task/docker/docker.go
+++ b/pkg/task/docker/docker.go
@@ -31,6 +31,14 @@ func (task *DockerTaskClient) close() error {
 
 func (task *DockerTaskClient) runTask(opts *taskModel.RunOptions) error {
 
+	// pull image
+	imageName := opts.Template.Image.Name()
+	if err := task.docker.PullImageOffline(imageName, func() {
+		task.eventBus.Publish(newImagePullDockerLoaderEvent(imageName))
+	}); err != nil {
+		return err
+	}
+
 	// taskName
 	containerName := opts.Template.GenerateName()
 
@@ -48,13 +56,6 @@ func (task *DockerTaskClient) runTask(opts *taskModel.RunOptions) error {
 		networkMode = docker.DefaultNetworkMode()
 	}
 
-	imageName := opts.Template.Image.Name()
-	if err := task.docker.PullImageOffline(imageName, func() {
-		task.eventBus.Publish(newImagePullDockerLoaderEvent(imageName))
-	}); err != nil {
-		return err
-	}
-
 	containerConfig, err := docker.BuildContainerConfig(&docker.ContainerConfigOpts{
 		ImageName: imageName,
 		Hostname:  "", // vpn NetworkMode conflicts with Hostname containerName
@@ -131,5 +132,6 @@ func (task *DockerTaskClient) runTask(opts *taskModel.RunOptions) error {
 	task.eventBus.Publish(newContainerLogDockerConsoleEvent(logFileName))
 
 	// remove temporary container
+	task.eventBus.Publish(newContainerRemoveDockerEvent(containerId))
 	return task.docker.Client.ContainerRemove(containerId)
 }
diff --git a/pkg/task/docker/events.go b/pkg/task/docker/events.go
index 68e98e0..31fcda2 100644
--- a/pkg/task/docker/events.go
+++ b/pkg/task/docker/events.go
@@ -59,3 +59,7 @@ func newContainerCreateDockerLoaderEvent() *dockerTaskEvent {
 func newContainerWaitDockerLoaderEvent() *dockerTaskEvent {
 	return &dockerTaskEvent{kind: event.LoaderStop, value: "waiting"}
 }
+
+func newContainerRemoveDockerEvent(containerId string) *dockerTaskEvent {
+	return &dockerTaskEvent{kind: event.LogInfo, value: fmt.Sprintf("container remove: containerId=%s", containerId)}
+}
diff --git a/pkg/task/kubernetes/events.go b/pkg/task/kubernetes/events.go
index 9302e4f..9ee65b1 100644
--- a/pkg/task/kubernetes/events.go
+++ b/pkg/task/kubernetes/events.go
@@ -35,3 +35,31 @@ func newCloseKubeClientEvent() *kubeTaskEvent {
 func newNamespaceApplyKubeEvent(namespace string) *kubeTaskEvent {
 	return &kubeTaskEvent{kind: event.LogInfo, value: fmt.Sprintf("namespace apply: namespace=%s", namespace)}
 }
+
+func newJobCreateStatusKubeEvent(status string) *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.LogDebug, value: status}
+}
+
+func newJobCreateKubeEvent(namespace string, name string) *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.LogInfo, value: fmt.Sprintf("job create: namespace=%s name=%s", namespace, name)}
+}
+
+func newJobDeleteKubeEvent(namespace string, name string) *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.LogInfo, value: fmt.Sprintf("job delete: namespace=%s name=%s", namespace, name)}
+}
+
+func newPodNameKubeEvent(namespace string, podName string, containerName string) *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.LogInfo, value: fmt.Sprintf("found unique pod: namespace=%s podName=%s containerName=%s", namespace, podName, containerName)}
+}
+
+func newPodLogKubeEvent(logFileName string) *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.LogInfo, value: fmt.Sprintf("pod log: logFileName=%s", logFileName)}
+}
+
+func newPodLogKubeConsoleEvent(logFileName string) *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.PrintConsole, value: fmt.Sprintf("output file: %s", logFileName)}
+}
+
+func newContainerWaitKubeLoaderEvent() *kubeTaskEvent {
+	return &kubeTaskEvent{kind: event.LoaderStop, value: "waiting"}
+}
diff --git a/pkg/task/kubernetes/kubernetes.go b/pkg/task/kubernetes/kubernetes.go
index fba79f7..7a875dd 100644
--- a/pkg/task/kubernetes/kubernetes.go
+++ b/pkg/task/kubernetes/kubernetes.go
@@ -31,8 +31,9 @@ func (task *KubeTaskClient) close() error {
 	return task.client.Close()
 }
 
-func (task *KubeTaskClient) runTask(opts *taskModel.RunOptions) error {
+// TODO copy vpn https://github.com/goccy/kubejob/blob/master/copy.go
 
+func (task *KubeTaskClient) runTask(opts *taskModel.RunOptions) error {
 	namespace := task.clientOpts.Namespace
 
 	// create namespace
@@ -63,31 +64,38 @@ func (task *KubeTaskClient) runTask(opts *taskModel.RunOptions) error {
 		Namespace: namespace,
 		Spec:      jobSpec,
 		OnStatusEventCallback: func(event string) {
-			// TODO task.eventBus.Publish(newDeploymentCreateStatusKubeEvent(event))
+			task.eventBus.Publish(newJobCreateStatusKubeEvent(event))
 		},
 	}
 	err := task.client.JobCreate(jobOpts)
 	if err != nil {
 		return err
 	}
-	// TODO task.eventBus.Publish
+	task.eventBus.Publish(newJobCreateKubeEvent(namespace, jobName))
 
 	podInfo, err := task.client.PodDescribeFromJob(jobSpec)
 	if err != nil {
 		return err
 	}
-	// TODO task.eventBus.Publish(newPodNameKubeEvent(namespace, podInfo.PodName, podInfo.ContainerName))
+	task.eventBus.Publish(newPodNameKubeEvent(namespace, podInfo.PodName, podInfo.ContainerName))
+
+	// stop loader
+	task.eventBus.Publish(newContainerWaitKubeLoaderEvent())
+
+	// TODO tee
+	logFileName := "TODO_LOG_FILE_NAME"
 
 	logOpts := &kubernetes.PodLogOpts{
 		Namespace: namespace,
 		PodName:   podInfo.PodName,
 		PodId:     podInfo.ContainerName,
 	}
-	// TODO task.eventBus.Publish
+	task.eventBus.Publish(newPodLogKubeEvent(logFileName))
 	if err := task.client.PodLog(logOpts); err != nil {
 		return err
 	}
 
-	// TODO task.eventBus.Publish
+	task.eventBus.Publish(newPodLogKubeConsoleEvent(logFileName))
+	task.eventBus.Publish(newJobDeleteKubeEvent(namespace, jobName))
 	return task.client.JobDelete(namespace, jobName)
 }