Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.py fails #29

Open
ffeppon opened this issue Apr 26, 2021 · 1 comment
Open

Setup.py fails #29

ffeppon opened this issue Apr 26, 2021 · 1 comment

Comments

@ffeppon
Copy link
Contributor

ffeppon commented Apr 26, 2021

Dear Hugo,

When installing the package, I think the setup.py should be slightly revised because the line

from beampy import __version__ as beampy_version

is problematic, since it tries to import packages on which beampy depends. I think it would be better practice to put the version il a separate .py file (if you need it also in the code) or in the setup.py itself.

Best
Florian

@hchauvet
Copy link
Owner

Why not, we could add a _version.py file with the __version__='X.Z.Y' variable in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants