[CLC-429]: Change cancel message on dmt start command #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuce
requested changes
Nov 10, 2023
| @@ -95,5 +98,6 @@ Selected data structures in the source cluster will be migrated to the target cl | |||
| } | |||
|
|
|||
| func init() { | |||
| cmd.SetCancelMsg(" (Ctrl+C to exit) ") | |||
There was a problem hiding this comment.
It's better to put this at the start of Exec, so it doesn't affect other commands.
yuce
requested changes
Nov 13, 2023
| Selected data structures in the source cluster will be migrated to the target cluster. | ||
| Selected data structures in the source cluster will be migrated to the target cluster. | ||
|
|
||
| (Pressing CTRL+C does not cancel the migration progress) |
There was a problem hiding this comment.
Suggested change
| (Pressing CTRL+C does not cancel the migration progress) | |
| Exiting the application does not affect the migration progress. | |
| In order to cancel the migration, use the 'cancel' command. |
yuce
approved these changes
Nov 13, 2023
srknzl
approved these changes
Nov 14, 2023
# Conflicts: # base/commands/migration/migration_start.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.