Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOID response type can be replaced with empty generated method. #249

Open
asimarslan opened this issue Oct 14, 2019 · 0 comments
Open

VOID response type can be replaced with empty generated method. #249

asimarslan opened this issue Oct 14, 2019 · 0 comments
Labels
2.x client protocol 2.x related

Comments

@asimarslan
Copy link
Contributor

Instead of

    public static XCodec.ResponseParameters decodeResponse(ClientMessage clientMessage) {
        ClientMessage.ForwardFrameIterator iterator = clientMessage.frameIterator();
        ResponseParameters response = new ResponseParameters();
        //empty initial frame
        iterator.next();
        return response;
    }

we can just leave this method empty or even not generate the method.

@asimarslan asimarslan added the 2.x client protocol 2.x related label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x client protocol 2.x related
Projects
None yet
Development

No branches or pull requests

1 participant