Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize env names #11

Closed
lopezator opened this issue Jun 4, 2019 · 2 comments
Closed

generalize env names #11

lopezator opened this issue Jun 4, 2019 · 2 comments

Comments

@lopezator
Copy link
Contributor

In order to open have a naming that makes sense when using different email providers, the proposal is to rename the following environment names from -> to:

MG_DOMAIN -> API_DOMAIN
MG_KEY -> API_KEY

So in #7 I can reuse them without incurring in a naming conflict.

We can keep this open until #7 comes, but wanted to open the issue to grab some feedback from you.

@haydenwoodhead
Copy link
Owner

haydenwoodhead commented Jun 5, 2019

I'm not sure about generalizing these environment variables. Not every email provider uses the same amount of environment variables. Sendgrid, for example, only uses one API key, or what about a hypothetical provider that needs four? I think it makes more sense to just have provider-specific variables. Then, if you aren't using that provider don't include them. This is the current strategy for databases (DATABASE_URL vs DYNAMO_TABLE).

My suggestion is to just create a new env var SG_KEY or SENDGRID_KEY. Thoughts?

@lopezator
Copy link
Contributor Author

That makes sense. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants