Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not start fetching remote data before initial UI #179

Open
KeenWarrior opened this issue Mar 21, 2017 · 8 comments
Open

Should not start fetching remote data before initial UI #179

KeenWarrior opened this issue Mar 21, 2017 · 8 comments
Assignees

Comments

@KeenWarrior
Copy link
Contributor

This issue is currently in generic format and need to be further detailed

@shubhamvashisht
Copy link
Collaborator

I want to work in it.

@shubhamvashisht
Copy link
Collaborator

@garg-anuj can we break it into details?

@KeenWarrior
Copy link
Contributor Author

@shubhamvashisht Approach I came up for this is. All aerogear pipe config and checking for auth should be moved after initial screen display. We can assume that auth state is same as last time app was visited.

@shubhamvashisht
Copy link
Collaborator

@garg-anuj as you mentioned the "initial screen display", is it about mainActivity before checking the auth status?

@KeenWarrior
Copy link
Contributor Author

we can move auth status check and configure pipe to separate thread s it doesn't hamper UI. Additionally we may save auth state from last usage of app and assume state is same. Until we get to find out from other thread that there is some change.

@shubhamvashisht
Copy link
Collaborator

@garg-anuj great, can we break it into phases? i will start working on it.

@KeenWarrior
Copy link
Contributor Author

@shubhamvashisht Move auth status check and configure pipe to separate thread as first mile stone

@m-murad
Copy link
Collaborator

m-murad commented Apr 16, 2017

@garg-anuj @shubhamvashisht @danielpassos
I think this will change the LoginActivity.java file.
If one is working on it, he should send the PR to @danielpassos branch.

(Just an opinion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants