Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show navigation drawer header dropdown only when there are multiple personas #164

Open
janakamarasena opened this issue Mar 18, 2017 · 8 comments

Comments

@janakamarasena
Copy link
Contributor

screenshot_20170318-215915

Right now the drop down button next to the persona is always visible even though there is only one persona; this can mislead users. Shall we have the dropdown invisible by default and make it visible when there are items in list_personas?

Shall I do this and send a PR

@m-murad
Copy link
Collaborator

m-murad commented Mar 18, 2017

@janakamarasena
I have a better idea.
Why not an option to add account just like Gmail.

What do you think?

@janakamarasena
Copy link
Contributor Author

@free4murad I think it is the intended plan going forward; need to think of proper UI layouts and more importantly how the app will work with multiple personas.

@KeenWarrior
Copy link
Contributor

@janakamarasena @free4murad There was concept of multiple persona early on which have been removed as per for current.

It is presently not confirm if android client will continue to have multiple account or not.

@janakamarasena
Copy link
Contributor Author

@garg-anuj shall I make the dropdown button invisible by default?

@KeenWarrior
Copy link
Contributor

@janakamarasena Go on

@m-murad
Copy link
Collaborator

m-murad commented Mar 19, 2017 via email

@KeenWarrior
Copy link
Contributor

@janakamarasena @free4murad Ok. you guys leave it. I will remove whole persona stuff in few days 😉

@m-murad
Copy link
Collaborator

m-murad commented Apr 16, 2017

@garg-anuj @danielpassos
if @janakamarasena is not working on this, can I remove the files and code related to multiple persona.

@janakamarasena janakamarasena removed their assignment Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants