Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: Dispute's trade is null #1364

Open
XMRZombie opened this issue Oct 30, 2024 · 3 comments
Open

ERROR: Dispute's trade is null #1364

XMRZombie opened this issue Oct 30, 2024 · 3 comments

Comments

@XMRZombie
Copy link
Contributor

Sometimes, there's peer who got external patches but disputes aren't closed on the GUI, it leaves error like this when trying to close the dispute and the app crashes

[JavaFX Application Thread] WARN  h.d.m.s.d.a.a.ArbitratorView: Dispute's trade is null for trade {scrubbed-trade-id}

Closing trades when trades/disputes are 'null' could fix that

@woodser
Copy link
Contributor

woodser commented Oct 30, 2024

Hm, I don't see how the dispute's trade should become null.

This warning is logged in the arbitrator's application when they try to close the dispute on their end, or it happens in the peer applications when the arbitrator closes the dispute?

Can you find removeTradeOnError() trade= in the logs as well?

I've opened a PR to add some logging but currently still don't know how the dispute's trade is null: #1366

@XMRZombie
Copy link
Contributor Author

The error happens on the arbitrator, not on peers

@woodser
Copy link
Contributor

woodser commented Oct 31, 2024

Does this continue to happen for recent trades on the latest version, or is this for an older trade that won't go away?

Do you see removeTradeOnError() trade={trade id} in the logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants