Always use 64-bit file offsets #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, OFD locking was broken on 32-bit, because it would somehow end up using the 64-bit fcntl() function, but pass it 32-bit off_t values in struct flock. To fix this, tell libc to use always use 64-bit file offsets. This is the same fix that was applied for a similar issue in GHC[1]. [1]: https://gitlab.haskell.org/ghc/ghc/-/commit/9853fc5e3556e733b56976b0a2fce9e82130a9ef Fixes: haskellari#15
|
@phadej Is it possible to merge this? And then also release a new version of lukko on Hackage? Thank you |
|
@phadej bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, OFD locking was broken on 32-bit, because it would somehow end up using the 64-bit
fcntl()function, but pass it 32-bitoff_tvalues instruct flock. To fix this, tell libc to use always use 64-bit file offsets.This is the same fix that was applied for a similar issue in GHC.
Fixes: #15