Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add Semigroup instances #348

Open
ndmitchell opened this issue Jun 13, 2017 · 3 comments
Open

Add Semigroup instances #348

ndmitchell opened this issue Jun 13, 2017 · 3 comments

Comments

@ndmitchell
Copy link
Contributor

At least for String, on newer base versions. Probably for arrays too.

@vincenthz
Copy link
Member

vincenthz commented Jul 8, 2017

I was going to make this quickly now but turn out this is really a bad class that is only >= 8.0 and using other stuff from >= 8.0 only (base's NonEmpty). so that brings lots of compat to write ...

@ndmitchell
Copy link
Contributor Author

Why not make it only available for people on 8.0 and above? That way you can either use foundation stuff, or if you are on the latest base, the type classes which are floating around anyway "just work".

@vincenthz
Copy link
Member

if you don't do the compat work at the class level, then all the deriving need to be #ifdef at every single place you instance/derive Semigroup. this is a one level of magnitude uglier than doing the compat work just like Foundation.Class.Bifunctor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants