Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monorepo structure and cleanup #383

Merged
merged 2,800 commits into from
Sep 3, 2024
Merged

Monorepo structure and cleanup #383

merged 2,800 commits into from
Sep 3, 2024

Conversation

LaurentRDC
Copy link
Member

@LaurentRDC LaurentRDC commented Aug 31, 2024 •
edited
Loading

This is a pull request that reforms the distributed-process repository into a monorepo, containing most relevant packages in the haskell-distributed organization.

See #382 for discussion

List of merged packages:

  • distributed-process-async
  • distributed-process-client-server
  • distributed-process-execution
  • distributed-process-extras
  • distributed-process-simplelocalnet
  • distributed-process-supervisor
  • distributed-process-systest
  • distributed-static
  • network-transport
  • network-transport-inmemory
  • network-transport-tcp
  • network-transport-tests
  • rank1dynamic

This PR also includes some cleanup, including:

  • Harmonizing the dependency versions of all packages in the repo, such that all packages can be build using GHC 8.10 up to GHC 9.10
  • Dropping support for GHC before 8.10, and simplifying all the CPP cruft
  • Cleaning up all cabal files;
  • Added an explicit CONTRIBUTING.md file.
  • Continuous testing on Ubuntu

TODO after merge:

  • Update the links to this repo for all affected packages on Hackage
  • Archive the merged repositories

qnikst and others added 30 commits November 25, 2017 15:57
@qnikst
Fix dependendencies and build.
5ef0250
@agentm
support GHC 8.2
c865323
@lorenzo
Using the latest stackage lts
63671ac
@OlivierSohn
Fix doc
53429e2
@facundominguez
Merge pull request #39 from OlivierSohn/master
121e40c 
Fix doc
@qrilka
Fix link to lifted-base
d11b7f4
@facundominguez
Merge pull request #42 from qrilka/patch-1
31b4268 
Fix link to lifted-base
@qrilka
Fixed link for distributed-process-async
73c6a01
@hyperthunk
Merge pull request #6 from lorenzo/latest-lts
40fb48c 
Using the latest stackage lts
@hyperthunk
Merge pull request #5 from agentm/master
b681027 
support GHC 8.2
@hyperthunk
Merge pull request #43 from qrilka/patch-2
3d36de6 
Fixed link for distributed-process-async
@hyperthunk
Merge pull request #38 from Abhiroop/master
8392088 
Make the code typecheck
@hyperthunk
Merge pull request #33 from teh/contact-slack
4c5f284 
Add slack & use bootstrap rows over image-height formatting.
@qnikst
Merge branch 'master' into master
ba95020
@qnikst
Merge pull request #13 from agentm/master
7fd3c4e 
support building with GHC 8.2.1
@facundominguez
Merge tag 'v0.6.0' into HEAD
6a67f49
Update cabal bug-reports
735cf1c
@qnikst
update min GHC version
7a33303 
rank1dynamic can't be built on GHC =< 7.8. This patch reflects that in dependency files.
@facundominguez
Merge pull request #21 from haskell-distributed/qnikst-patch-1
57c87db 
update min GHC version
@Acentelles
Update dependencies
253878d
@Acentelles
Use distributed-process-systest-0.2.0
14b75d7
@Acentelles
Update dependencies
4db4c0d
@Acentelles
Remove extra dependency
c1133b4
@Acentelles
Bump version
b9b2304
@Acentelles
Update dependencies
edeaa4b
@Acentelles
Change distributed-process dep upper and lower bound
57dca3a
@Acentelles
Change distributed-process dep upper and lower bound
cccf008
@sdiehl
Merge pull request #1 from adjoint-io/update-deps
8db4a79 
Update dependencies
@sdiehl
Merge pull request #1 from adjoint-io/update-deps
fbfce30 
Update dependencies
@sdiehl
Merge pull request #1 from adjoint-io/update-deps
1651ffa 
Update deps
@LaurentRDC LaurentRDC changed the title Monorepo structure Monorepo structure and cleanup Aug 31, 2024
@LaurentRDC LaurentRDC marked this pull request as ready for review September 2, 2024 18:47
@LaurentRDC LaurentRDC requested a review from davidsd September 2, 2024 18:47
@LaurentRDC
Copy link
Member Author

@davidsd This pull request is huge, so I can't expect anyone to actually review it.

Would you confirm to me that your workflow still works though? Can you build e.g. distributed-process?

I think you use Slack but I don't, so I'm not sure whether things still work.

davidsd
davidsd approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@davidsd davidsd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding an extra-deps field for rematch in the stack.yaml files, I was able to build everything. It looks good to me!

@davidsd
Copy link
Contributor

davidsd commented Sep 2, 2024

I'm not sure what's going on with the one failing test.

@LaurentRDC
Copy link
Member Author

Some of the tests are quite flaky. There's an option to rerun failed runs on Github actions, which I had to use a lot

@davidsd
Copy link
Contributor

davidsd commented Sep 3, 2024

Regarding renaming this repo, I vote against. I think the name "distributed-process" makes sense, since it is the name of the "main" package here, and also the prefix of several other packages here. These are the names people will see on hackage when they search for this functionality -- they will likely not know what "cloud haskell" is unless they read some of the literature from around when cloud haskell was born.

@LaurentRDC
Copy link
Member Author

Makes sense, no name changes

@LaurentRDC LaurentRDC merged commit a8f1003 into master Sep 3, 2024
20 of 21 checks passed
@LaurentRDC
Copy link
Member Author

In the end, the website must be published from a special repo with the organization name for it to be published at haskell-distributed.github.io.

@joelmccracken
Copy link
Member

I see you're building a bikeshed and deciding on the color! May I just comment that I've noticed some confusion around the difference between "cloud haskell" and "distributed process", and I suspect that renaming back may somehow cause additional confusion?

@LaurentRDC
Copy link
Member Author

LaurentRDC commented Sep 3, 2024 •
edited
Loading

@joelmccracken Do not worry, I will not rename this repository.

To address potential confusion about Cloud Haskell / distributed-process, I have created an organization README: https://github.com/haskell-distributed/.github/blob/main/profile/README.md

@joelmccracken
Copy link
Member

@joelmccracken Do not worry, I will not rename this repository.

To address potential confusion about Cloud Haskell / distributed-process, I have created an organization README: https://github.com/haskell-distributed/.github/blob/main/profile/README.md

Beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsd davidsd davidsd approved these changes

Assignees

@LaurentRDC LaurentRDC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.