Expose ghcup binary location #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
enhance/expose-ghcup-exe
branch
from
0a3e4b0 to
c58e932
Compare
andreasabel
requested changes
May 13, 2024
| @@ -45,6 +45,8 @@ outputs: | |||
| description: 'The resolved version of stack' | |||
| ghc-exe: | |||
| description: 'The path of the ghc _executable_' | |||
| ghcup-command: | |||
| description: 'The path of the ghcup _executable_' | |||
There was a problem hiding this comment.
- We should check whether the
-exeoutputs are indeed absolute paths. - The help text here should not say "path" but something like "The command to invoke ghcup (might not be an absolute path)".
There was a problem hiding this comment.
We should check whether the -exe outputs are indeed absolute paths.
Any hints for writing a test? I don't see right away where such a test could be added.
There was a problem hiding this comment.
Good question!
There is some code in CI that validates the -version outputs of the actions, maybe something similar could be done for the -exe outputs:
setup/.github/workflows/workflow.yml
Lines 166 to 174 in 64f55f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Let the bikeshedding commence :)