VAULT-32568: Shutdown node when it's not in the raft config #29052
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
requested review from
digivava,
raskchanky,
kubawi and
bosouza
and removed request for
a team
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results:
|
|
Build Results: |
kubawi
reviewed
Nov 28, 2024
| @@ -1391,6 +1402,9 @@ func (b *RaftBackend) SetupCluster(ctx context.Context, opts SetupOpts) error { | |||
| } | |||
| } | |||
|
|
|||
| if opts.RemovedCallback != nil { | |||
| b.removedCallback = opts.RemovedCallback | |||
There was a problem hiding this comment.
Should this be a call to SetRemovedCallback instead? (Genuine question, I am not sure if we care about locking at this point.)
kubawi
approved these changes
Nov 28, 2024
| @@ -1030,6 +1031,12 @@ func (b *RaftBackend) SetRestoreCallback(restoreCb restoreCallback) { | |||
| b.fsm.l.Unlock() | |||
| } | |||
|
|
|||
| func (b *RaftBackend) SetRemovedCallback(cb func()) { | |||
There was a problem hiding this comment.
Suggested change
| func (b *RaftBackend) SetRemovedCallback(cb func()) { | |
| func (b *RaftBackend) setRemovedCallback(cb func()) { |
Can we leave this function unexported?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a removed node shutdown if it sees that it's not in the raft configuration. For extra safety's sake, the node must have previously been present in the configuration in order for the node to shutdown.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.