fix boolean short-circuit diagnostic handling #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no test looking for dropped diagnostics when boolean opts don't short-circuit. The missing diagnostics were what made some of the tests from the original PR pass through, so a correction to that will follow.
Drop RHS diagnostics when bot boolean op expression values are unknown. This allows skipping an evaluation error on the RHS in case we can short-circuit when the LHS is known.
dsa0x
approved these changes
Dec 17, 2024
|
@hashicorp/team-ip-compliance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #713.
A couple boolean expression tests were passing because diagnostics were accidentally dropped when there was no short-circuit return. Add a positive test for the diagnostics and make sure they are always collected from both sides of the expression.
The logic to drop diagnostics needed to be within the short-circuit implementations, where a good LHS unknown value (one without any errors) prevents further evaluation allowing us to optimistically skip the RHS diagnostics. This can be confusing, because the logic looked correct, but we need to remember that cty/hcl return an unknown value when faced with errors too, and part of the short-circuit logic is to selectively handle errors when possible.