Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-hardcode vault token monitoring in watcher #28

Open
eikenb opened this issue Nov 30, 2020 · 0 comments
Open

un-hardcode vault token monitoring in watcher #28

eikenb opened this issue Nov 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@eikenb
Copy link
Contributor

eikenb commented Nov 30, 2020

The watcher has a hardcoded field for monitoring the vault-token as part of its process. This means for testing the vault-token you need to spin up a watcher with that config.

Seems like it would be better to integrate it without the hardcoding. In a way that would be easier to test.

I've refactored this already in consul-template and should use that as a guide to convert here after the non-template notifiers work.

@eikenb eikenb added the enhancement New feature or request label Nov 30, 2020
@eikenb eikenb self-assigned this Nov 30, 2020
@eikenb eikenb removed their assignment Sep 24, 2021
@eikenb eikenb changed the title consider un-hardcode vault token monitoring in watcher un-hardcode vault token monitoring in watcher Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant