fix: Set the designated payer when building an EVM transactions from scheduled transactions

[JivkoKelchev]

Description:
Updates the hevmTransactionFactory to accept the payer instead of extracting it from the transaction ID, while building from hapi transaction. This is needed because scheduled transactions inherited their ID from scheduleCreate transactions, and may have a different payer.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.53%. Comparing base (0c23fbb) to head (3009d36).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #16708      +/-   ##
=============================================
- Coverage      63.53%   63.53%   -0.01%     
+ Complexity     20372    20371       -1     
=============================================
  Files           2537     2537              
  Lines          94757    94754       -3     
  Branches        9904     9904              
=============================================
- Hits           60206    60200       -6     
- Misses         30946    30948       +2     
- Partials        3605     3606       +1     

Files with missing lines	Coverage Δ
...ontract/impl/exec/ContextTransactionProcessor.java	80.55% <100.00%> (ø)
...ce/contract/impl/infra/HevmTransactionFactory.java	92.30% <100.00%> (-0.18%)	⬇️

... and 1 file with indirect coverage changes

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (0c23fbb)	97522	63622	65.24%
Head commit (3009d36)	97519 (-3)	63617 (-5)	65.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#16708)	4	4	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[Nana-EC]

@JivkoKelchev can you add more details to this PR.
Also let's discuss this a bit more, my understanding is this is enabling the scheduling of a ContractCall transaction.
Can we enable this only in dev & previewnet at this juncture while this is explored more.
Same for all Smart contract transactions
FYI @netopyr and @lukelee-sl

[JivkoKelchev]

Hi @Nana-EC ,

This change was needed because scheduled transactions inherit their transaction ID from their initial ScheduleCreate transaction.

In this case, we want a custom payer that will pay the gas. So we need a way to provide the payer (contract call sender) instead of extracting the one from the transaction ID, while creating the HederaEvmTransaction here.

However, I’m not really sure if we still need these changes, since @tinker-michaelj did significant refactoring of the long-term schedule implementation. What do you think Michael?

[tinker-michaelj]

LGTM, tyvm @JivkoKelchev !