Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include engineering teams as codeowners on additional files #16701

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PavelSBorisov
Copy link
Member

Description:

  • Include engineering teams as codeowners on additional files

Related issue(s):

Fixes #16692

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@PavelSBorisov PavelSBorisov added this to the v0.57 milestone Nov 21, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners November 21, 2024 08:25
@PavelSBorisov PavelSBorisov self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.53%. Comparing base (0c23fbb) to head (8003ad8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16701   +/-   ##
==========================================
  Coverage      63.53%   63.53%           
  Complexity     20372    20372           
==========================================
  Files           2537     2537           
  Lines          94757    94757           
  Branches        9904     9904           
==========================================
  Hits           60206    60206           
  Misses         30946    30946           
  Partials        3605     3605           

Impacted file tree graph

Copy link

codacy-production bot commented Nov 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0c23fbb) 97522 63622 65.24%
Head commit (8003ad8) 97522 (+0) 63622 (+0) 65.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16701) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
@rbarkerSL
Copy link
Contributor

Any updates here?

@PavelSBorisov
Copy link
Member Author

Any updates here?

Aren't we still awaiting confirmation on the /hapi/ directory approvers groups?

@poulok @netopyr is this the right approvers group for the hapi directory structure?

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
@PavelSBorisov PavelSBorisov force-pushed the 16692-include-engineering-teams-as-codeowners-on-additional-files branch from c6713d6 to ce19967 Compare November 27, 2024 13:16
@PavelSBorisov PavelSBorisov force-pushed the 16692-include-engineering-teams-as-codeowners-on-additional-files branch from ce19967 to 8003ad8 Compare November 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include engineering teams as codeowners on additional files
4 participants