Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create gtfs_routes endpoint that combines routes based on the route short name #33

Open
shootermv opened this issue Nov 5, 2023 · 4 comments

Comments

@shootermv
Copy link
Contributor

shootermv commented Nov 5, 2023

currently gtfs_routes/list endpoint brings routes which is not convenient for being used at client:
image
there is a difference between 2 and 3 routes, but for a client they should be the same
thus: we need to create endpoint that combines routes based on the route short name

@ofirshtrosberg
Copy link

If still relevant I can take this issue @shootermv @NoamGaash

@NoamGaash
Copy link
Member

@ofirshtrosberg currently the client side perform string manipulation to separate the parts of this fields. If you can return a structured form that could be great!

@ofirshtrosberg
Copy link

@NoamGaash If you want, you can provide me a schema example that will be most convenient for Frontend use.

@NoamGaash
Copy link
Member

NoamGaash commented Jul 28, 2024

It's up to you,
I imagine something like

{
"origin": "היכל המשפט/אבא-אבן ירושלים",
"destination": "מיצד א-אספר",
"city": "ירושלים",
"alternative": "#1",
}

But I think the best practice would be aligning to the names of the backend entities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants