Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snps_gr example file #9

Open
caalo opened this issue Sep 8, 2023 · 1 comment
Open

Add snps_gr example file #9

caalo opened this issue Sep 8, 2023 · 1 comment

Comments

@caalo
Copy link
Collaborator

caalo commented Sep 8, 2023

It's great that you have test.bw and test.csv.zst in the package to give the user a demo. Can you add a GRanges file for snps_gr variable in GetMandS() function so that I can run through the Example you wrote for GetMandS() without an error?

@caalo
Copy link
Collaborator Author

caalo commented Sep 8, 2023

Oh, I see that if snps_gr=NULL the argument value, then it will try to download the snps_gr file.
However, the file https://livejohnshopkins-my.sharepoint.com/:u:/r/personal/arazi2_jh_edu/Documents/RecountGenotyper/biallelic_SNP_gr.rds?csf=1&web=1&e=glKCqA link is broken.

Let's find a place to host the SNPs and model file!!

There is also a issue in the example documentation -- you have:

test_geno<-GetMandS(snps_gr, bigWig_path, alt_path, sample_id_rep, temp_folder=tempdir())

it should be

 test_geno<-GetMandS(snps_gr=NULL, bigWig_path, coverage_cutoff=4, alt_path, sample_id_rep, temp_folder= tempdir())

because you want the user to use the default snps_gr, and by not saying anything about coverage_cutoff you shift all the arguments one over. Usually, when you have arguments that have a default value such as snps_gr and coverage_cutoff, you should have them to be the last arguments to prevent confusion. (this might be a bad habit carry-over from my own code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant