Factur-X Version updated

[zealot128]

• Refac: also changed factur-x folder for future updates

Process for updating

• download ZUGFeRD zip here https://www.ferd-net.de/standards/paket-downloads/index.html
• unzip, copy folder factur-x content into schemas

Another refac idea:
Adding of a Version class that encapsulates the various validation file would be helpful? Maybe even use a version symbol, like to_xml(version: :factur_1) or to_xml(version: :zugferd1)? Could try to add it, if you also feel that would be an improvement.

[halfbyte]

Another refac idea:
Adding of a Version class that encapsulates the various validation file would be helpful? Maybe even use a version symbol, like to_xml(version: :factur_1) or to_xml(version: :zugferd1)? Could try to add it, if you also feel that would be an improvement.

To be honest, I think I'd be leaning more towards separate classes for the various formats to get rid of the if/else constructs entirely. Means a lot of duplication but I think it might be worth it for its explicitness and would make the builder constructs more readable. What do you think?

(Would also make it much easier to integrate things like XRechnung with potentially very different XML structures)

[halfbyte]

@zealot128 Quick note for next time (I didn't catch it as well in your PR) - The filename of the ReusableAggregateBusinessInformationEntity is too long for gem build which is why I renamed the file (And then you have to change the file reference in the root xsd as well - See 45ba1cf)

Bit of a bummer but it is what it is - I would like to keep the schema in the gem to be able to use the validators.

[zealot128]

TIL 😀 thx for the info!Von meinem iPhone gesendetAm 04.12.2024 um 16:36 schrieb Jan Krutisch ***@***.***>: @zealot128 Quick note for next time (I didn't catch it as well in your PR) - The filename of the ReusableAggregateBusinessInformationEntity is too long for gem build which is why I renamed the file (And then you have to change the file reference in the root xsd as well - See 45ba1cf) Bit of a bummer but it is what it is - I would like to keep the schema in the gem to be able to use the validators. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>