Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color names in data result cause issues with VictoryCharts #914

Closed
jaronheard opened this issue Sep 6, 2019 · 2 comments
Closed

Color names in data result cause issues with VictoryCharts #914

jaronheard opened this issue Sep 6, 2019 · 2 comments
Labels

Comments

@jaronheard
Copy link
Contributor

jaronheard commented Sep 6, 2019

Description

Charts do not like color values in the data. This is probably why:

// VictoryPie uses d3-interpolate to perform animations. d3-interpolate
// “sanitizes” all values, despite whether or not they are used for an animation.
// This results in english words that happen to also be valid html/css color names
// become rgb(x, x, x) strings.

See a number of examples on
http://civicplatform.org/2019/housing

image

image

image

Steps to reproduce

Visit http://civicplatform.org/2019/housing -- should also replicate in Storybook.

Expected result

Charts should look good.

Actual result

See above

Environment

All environments

@jaronheard jaronheard added the bug label Sep 6, 2019
@jaronheard
Copy link
Contributor Author

More information:
FormidableLabs/victory#928

@jaronheard
Copy link
Contributor Author

#858 resolved.

Pass the protect prop to your components to prevent color names from being sanitized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant