You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you look at the network tab (especially on civicplatform.org/cards), you will see that API requests are being triggered for all of the cards previewed on the page, despite the previews not showing a visualization.
The API call is triggered in the index.js file for the card.
For this bug to be considered fixed, the following should be completed:
Find an approach that will prevent CardLayouts that don't include the visualization from triggering an API call
This approach is applied to all existing cards
NewCard hygen template updated to use this pattern
jaronheard
changed the title
Card layouts that don't include a visualization will trigger an API call.
Card layouts that don't include a visualization will trigger an unecessary API call
Oct 21, 2019
Description
If you look at the network tab (especially on civicplatform.org/cards), you will see that API requests are being triggered for all of the cards previewed on the page, despite the previews not showing a visualization.
The API call is triggered in the
index.js
file for the card.For this bug to be considered fixed, the following should be completed:
Steps to reproduce
Go to one of the following pages with the network tab of developer tools open:
http://civicplatform.org/cards/
http://civicplatform.org/cards/holc-redlining
Observe requests to different endpoints under service.civicpdx.org
Expected result
Should only make API calls for card layouts where visualizations are shown
Actual result
Makes API calls for all card layouts, including previews that only show card text
Environment
Production environment
The text was updated successfully, but these errors were encountered: