Skip to content

Commit

Permalink
Hck lodash failing browser test fix (#98)
Browse files Browse the repository at this point in the history
* HCK: add lodash to external dependencies list

* HCK: updated bundling config to load lodash from node_modules
  • Loading branch information
WilhelmWesser authored Nov 22, 2024
1 parent faedb33 commit b4e9575
Show file tree
Hide file tree
Showing 3 changed files with 157 additions and 0 deletions.
8 changes: 8 additions & 0 deletions esbuild.package.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const fs = require('fs');
const path = require('path');
const esbuild = require('esbuild');
const { clean } = require('esbuild-plugin-clean');
const { copy } = require('esbuild-plugin-copy');
const { copyFolderFiles, addReleaseFlag } = require('@hackolade/hck-esbuild-plugins-pack');
const { EXCLUDED_EXTENSIONS, EXCLUDED_FILES, DEFAULT_RELEASE_FOLDER_PATH } = require('./buildConstants');

Expand All @@ -22,10 +23,17 @@ esbuild
outdir: RELEASE_FOLDER_PATH,
minify: true,
logLevel: 'info',
external: ['lodash'],
plugins: [
clean({
patterns: [DEFAULT_RELEASE_FOLDER_PATH],
}),
copy({
assets: {
from: [path.join('node_modules', 'lodash', '**', '*')],
to: [path.join('node_modules', 'lodash')],
},
}),
copyFolderFiles({
fromPath: __dirname,
targetFolderPath: RELEASE_FOLDER_PATH,
Expand Down
148 changes: 148 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"@typescript-eslint/parser": "7.11.0",
"esbuild": "0.20.2",
"esbuild-plugin-clean": "1.0.1",
"esbuild-plugin-copy": "2.1.1",
"eslint": "8.57.0",
"eslint-config-prettier": "9.1.0",
"eslint-formatter-teamcity": "^1.0.0",
Expand Down

0 comments on commit b4e9575

Please sign in to comment.