Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using glhd/airephp as a form builder instead of laravelcollective/html #183

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Using glhd/airephp as a form builder instead of laravelcollective/html #183

merged 4 commits into from
Jan 12, 2024

Conversation

bogdankharchenko
Copy link
Collaborator

@bogdankharchenko bogdankharchenko commented Oct 19, 2023 •
edited
Loading

#180 this is a take on this issue - which replaces the laravelcollective/html package - with glhd/aire-bootstrap - this does the same thing as the laravel collective package, but looks a lot cleaner.

New Code

Screenshot 2023-10-19 at 2 31 58 PM

@bogdankharchenko bogdankharchenko marked this pull request as draft October 19, 2023 18:36
@bogdankharchenko
Copy link
Collaborator Author

This only changes the contact form - the sign-up form is the other place which will need to be updated. If this is approved, I will make changes there too.

@bogdankharchenko bogdankharchenko changed the title Using Airephp as a form builder Using glhd/airephp as a form builder instead of laravelcollective/html Oct 19, 2023
@oliviasculley
Copy link
Member

I'm a bit lazy and haven't previewed these changes, but just reading about aire seems to imply that it uses tailwind classes by default, and I'm not sure if it'd work since I don't think that tailwind is set up in this project. While the fix is probably just specifying the bootstrap classes manually, I wouldn't mind switching to bootstrap to tailwind :)

@bogdankharchenko
Copy link
Collaborator Author

Aire allows the templating, it's currently using (in this demo) bootstrap theme but if we ever decide to twice to tailwind it's an easy transition.

@bogdankharchenko bogdankharchenko marked this pull request as ready for review December 12, 2023 15:11
@bogdankharchenko bogdankharchenko requested review from ThorntonMatthewD and irby and removed request for allella, zach2825 and oliviasculley December 12, 2023 15:11
@bogdankharchenko
Copy link
Collaborator Author

I went ahead and converted the slack join page into aire as well, removed the abandoned package laravelcollective/html

@allella allella linked an issue Dec 12, 2023 that may be closed by this pull request
"Package laravelcollective/html is abandoned, you should avoid using it. Use spatie/laravel-html instead." #180
Closed
@bogdankharchenko
Copy link
Collaborator Author

@allella merge it!

@allella allella merged commit bdf7e07 into hackgvl:develop Jan 12, 2024
1 check passed
@allella allella mentioned this pull request Jan 12, 2024
Closed
@bogdankharchenko bogdankharchenko mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allella allella allella approved these changes

@ThorntonMatthewD ThorntonMatthewD Awaiting requested review from ThorntonMatthewD

@irby irby Awaiting requested review from irby

Assignees

@bogdankharchenko bogdankharchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Package laravelcollective/html is abandoned, you should avoid using it. Use spatie/laravel-html instead."
3 participants
@bogdankharchenko @oliviasculley @allella