-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Marlena Mellody Khim Sai to the LA TDM Calculator leadership page #7716
Added Marlena Mellody Khim Sai to the LA TDM Calculator leadership page #7716
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD Sunday(11/10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mchait18, thanks for taking this issue!
- the PR contains the correct branch
- issue is correctly linked
- changes are verified across browsers (firefox, edge, chrome)
- code changes are accurate and concise
- no other notable issues
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mchait18 , thank you for taking this issue.
What went well:
- The branch name is correct
- The before and after screenshots are great!
- The description is really clear and concise makes it easy for anyone to understand what was done.
Some suggestions
- On the original issue you need to respond to the Bot in the comments below
- You also need to change the original issue label from
Prioritized backlog
toIn progress
Great Job , Keep it up!
Thanks. What do you mean by the "original issue" in terms of responding to the bot and changing the label? |
Hi @mchait18 , the original issue is the one you mentioned in your PR (Fix #issue number).
|
Got it. Thanks. Do you know when this will be merged so that I can start my next issue? |
Hi @mchait18 - Thanks for your contribution. Reminder to finish the remaining action items listed in the issue now that this PR is merged. |
Fixes #7649
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied