Deleted the file assets/images/join-us/donation-graphic.svg

[ndmoc]

Fixes #4466

What changes did you make?

• I removed the donation-graphic.svg file from the assets directory

Why did you make the changes (we will use this info to test)?

• Task: Delete the file assets/images/join-us/donation-graphic.svg because it was unused
• Deleting the file would ensure that there wouldn't be any confusion on unused images and clean up the folder with unnecessary files

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ndmoc-remove-assets-joinus-donation-graphic-4466 gh-pages
git pull https://github.com/ndmoc/website.git remove-assets-joinus-donation-graphic-4466

[antho-zng]

Availability: M-F 9-5
ETA: 9/1

[antho-zng]

Looks good! Join Us page on local page looks the same as on the live webpage. Thanks!

[adrianang]

Hi @ndmoc — the branching is set up correctly, the corresponding issue was linked, and the requested change of removing the donation-graphic.svg file was made without affecting the Join Us page, but I have two small requests for you to edit and update your PR.

• As you had noted within the <details> tag, the image was unused and did not result in visual changes; since there are no visual changes, can you delete the entire Screenshots section in your PR? This will help keep our codebase documentation clean and it's a bit more obvious at first glance that there are no visual changes from this PR when this is deleted.
• The Why of your PR could explain the change a bit more thoroughly; looking at the linked issue, the reason the file was to be deleted is because it is unused and deleting it would "keep the file system clean and avoid confusion". Can you update the Why section of your PR with a bit more explanation, closer to the Overview in the linked issue?

Other than those changes, everything is looking good so far!

[ndmoc]

Hi @ndmoc — the branching is set up correctly, the corresponding issue was linked, and the requested change of removing the donation-graphic.svg file was made without affecting the Join Us page, but I have two small requests for you to edit and update your PR.

• As you had noted within the <details> tag, the image was unused and did not result in visual changes; since there are no visual changes, can you delete the entire Screenshots section in your PR? This will help keep our codebase documentation clean and it's a bit more obvious at first glance that there are no visual changes from this PR when this is deleted.
• The Why of your PR could explain the change a bit more thoroughly; looking at the linked issue, the reason the file was to be deleted is because it is unused and deleting it would "keep the file system clean and avoid confusion". Can you update the Why section of your PR with a bit more explanation, closer to the Overview in the linked issue?

Other than those changes, everything is looking good so far!

Thank you for the feedback Adrian. I removed the screenshot section and added an explanation regarding the issue's overview. I will be more specific moving forward! Thank you

[adrianang]

Thank you for making those changes! The PR looks good to me now; thank you for taking up this issue and contributing to HfLA! 🙌🏼