-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiran98118 span update #5396
Kiran98118 span update #5396
Conversation
… the future and avoid any merge conflicts due to divergent history
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 9pm 8/31/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice formatting catch on the unnecessary closing / on the img tag, but our pull requests should only address the changes specified in the original issue (in case the other fixes we catch show up in other existing issues).
Please resubmit with just the span update—otherwise looks great!
Hi @kiran98118! Thanks for working on this issue! I saw you moved the related issue #5368 back to the backlog. If you still plan to complete the changes, please move the original issue back to the |
Working on this review Monday 9/11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kiran98118
Thank you for working on this issue!
-You attached the issue number to the PR
-You are committing into the correct branch
-You navigate to _includes/about-page/about-card-platform.html and added the closing correctly
Awesome job!
When reviewing the changed files attached to this PR I'm also seeing changes to _includes/about-page/about-card-donations.html which were not in the instructions of issue #5368.
Please clarify why changes were made to _includes/about-page/about-card-donations.html or revert changes to the file. Once changes are made or clarification is given use the re-request review icon next to my name at the top right of this PR, in the conversation tab.
Dev opened a second PR for this issue #5457 that replaces this PR. |
Fixes #5368
What changes did you make?
-I have added the missing span tag
Why did you make the changes (we will use this info to test)?
-To solve the linter error
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)