Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiran98118 span update #5396

Closed

Conversation

kiran98118
Copy link
Contributor

Fixes #5368

What changes did you make?

-I have added the missing span tag

Why did you make the changes (we will use this info to test)?

-To solve the linter error

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • no visual change

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kiran98118-kiran98118_span_update gh-pages
git pull https://github.com/kiran98118/website.git kiran98118_span_update

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 31, 2023
@antho-zng antho-zng self-requested a review August 31, 2023 20:50
@antho-zng
Copy link
Member

Review ETA: 9pm 8/31/23
Availability: 12-9pm Thursday 8/31/23

Copy link
Member

@antho-zng antho-zng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice formatting catch on the unnecessary closing / on the img tag, but our pull requests should only address the changes specified in the original issue (in case the other fixes we catch show up in other existing issues).

Please resubmit with just the span update—otherwise looks great!

@LRenDO
Copy link
Member

LRenDO commented Sep 6, 2023

Hi @kiran98118!

Thanks for working on this issue! I saw you moved the related issue #5368 back to the backlog. If you still plan to complete the changes, please move the original issue back to the In Progress (actively working) and reassign yourself. Either way, please leave a comment to let us know whether or not you plan to complete the changes. Also, feel free to ping me if you need any help or clarification! Thanks!

@LukeLowrey2
Copy link
Member

Working on this review Monday 9/11
Availably: Monday 9/11 930a - 1030a, Tuesday 9/12 10a - 11a
ETA: Tuesday 9/12 EOD

Copy link
Member

@LukeLowrey2 LukeLowrey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kiran98118

Thank you for working on this issue!
-You attached the issue number to the PR
-You are committing into the correct branch
-You navigate to _includes/about-page/about-card-platform.html and added the closing correctly

Awesome job!

When reviewing the changed files attached to this PR I'm also seeing changes to _includes/about-page/about-card-donations.html which were not in the instructions of issue #5368.

Please clarify why changes were made to _includes/about-page/about-card-donations.html or revert changes to the file. Once changes are made or clarification is given use the re-request review icon next to my name at the top right of this PR, in the conversation tab.

@t-will-gillis
Copy link
Member

Dev opened a second PR for this issue #5457 that replaces this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Diversity
5 participants