Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "External Resources" card on Toolkit page to use icon-github.svg #6910

Closed
3 tasks done
roslynwythe opened this issue May 29, 2024 · 3 comments · Fixed by #6985
Closed
3 tasks done

Update "External Resources" card on Toolkit page to use icon-github.svg #6910

roslynwythe opened this issue May 29, 2024 · 3 comments · Fixed by #6985
Assignees
Labels
Complexity: Medium Feature: Refactor HTML P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented May 29, 2024

Overview

We need to update the code that renders the "External Resources" section on the Toolkit page, to reference the GitHub graphic file _includes/svg/icon-github.svg, and also to remove _includes/svg/icon-github-small.svg . These changes will eliminate a duplicate GitHub graphic file, resulting in a cleaner codebase.

Action Items

  • Update _data/internal/toolkitresources.yml and _sass/components/_toolkit.scss if needed, so that the"External Resources" card on the Toolkit webpage references the graphic file _includes/svg/icon-github.svg in place of the current file _includes/svg/icon-github-small.svg
  • Remove the file _includes/svg/icon-github-small.svg
  • Use Docker to preview the Toolkit page (/toolkit) to confirm that the appearance and behavior of the GitHub icon is unchanged

Resources/Instructions

_data/internal/toolkitresources.yml
Toolkit webpage

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing Complexity: Medium size: 0.5pt Can be done in 3 hours or less labels May 29, 2024
@github-actions github-actions bot removed Complexity: Medium size: 0.5pt Can be done in 3 hours or less labels May 29, 2024

This comment was marked as outdated.

@roslynwythe roslynwythe added role: front end Tasks for front end developers P-Feature: Toolkit https://www.hackforla.org/toolkit/ Feature: Refactor HTML Complexity: Medium size: 0.5pt Can be done in 3 hours or less Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels May 29, 2024
@roslynwythe roslynwythe changed the title Update Resource card on Project pages to use icon-github.svg Update Resource card on Project pages to use icon-github.svg May 29, 2024
@roslynwythe roslynwythe changed the title Update Resource card on Project pages to use icon-github.svg Update "External Resources" card on Toolkit page to use icon-github.svg May 29, 2024
@roslynwythe roslynwythe added Draft Issue is still in the process of being created Ready for Prioritization and removed Ready for Prioritization Draft Issue is still in the process of being created labels May 29, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the x. Technical debt milestone Jun 2, 2024
@aidanwsimmons aidanwsimmons self-assigned this Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Hi @aidanwsimmons, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@aidanwsimmons
Copy link
Member

aidanwsimmons commented Jun 6, 2024

Availability: weekday afternoons, weekend mornings
ETA: Monday EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor HTML P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

3 participants