Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER: duplicate GitHub icons and inconsistent locations #6903

Closed
1 of 3 tasks
roslynwythe opened this issue May 28, 2024 · 4 comments
Closed
1 of 3 tasks

ER: duplicate GitHub icons and inconsistent locations #6903

roslynwythe opened this issue May 28, 2024 · 4 comments
Assignees
@roslynwythe
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Feature: Refactor HTML Issue Making: Level 2 Make issue(s) from an ER or Epic role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone
x. Technical debt

Comments

@roslynwythe
Copy link
Member

roslynwythe commented May 28, 2024 •
edited
Loading

Emergent Requirement - Problem

We have 4 slack icons in the code base, all with different names and locations. We should only have one of each color, that we use everywhere.

Issue you discovered this emergent requirement in

Date discovered

2023-10-23

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@jefflueck @ExperimentsInHonesty

What happens if this is not addressed

  • redundancy in code
  • hard to change out the icon for any new icon

Resources

list of icons:

_includes/svg/icon-github.svg

image

_includes/svg/icon-github-color.svg

image

Recommended Action Items

  • Make a new issue as described below

Potential solutions [draft]

The proposed strategy is to retain _includes/svg/icon-github.svg and remove all others
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: 0.25pt Can be done in 0.5 to 1.5 hours ER Emergent Request role missing Complexity: Missing Draft Issue is still in the process of being created labels May 28, 2024
@roslynwythe roslynwythe self-assigned this May 28, 2024
@github-actions github-actions bot removed the Draft Issue is still in the process of being created label May 28, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@roslynwythe roslynwythe changed the title ER: ER: duplicate GitHub icons and inconsistent locations ER: duplicate GitHub icons and inconsistent locations May 28, 2024
@roslynwythe roslynwythe added Draft Issue is still in the process of being created Feature: Refactor HTML Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Issue Making: Level 2 Make issue(s) from an ER or Epic role: front end Tasks for front end developers and removed Complexity: Missing role missing Feature Missing This label means that the issue needs to be linked to a precise feature label. labels May 28, 2024
This was referenced May 29, 2024
Closed
Closed
Closed
Open
@roslynwythe roslynwythe added Ready for Prioritization and removed Draft Issue is still in the process of being created labels May 29, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the x. Technical debt milestone Jun 2, 2024
@ExperimentsInHonesty
Copy link
Member

@roslynwythe This ER needs a reference to the Slack issue where this is being done, since there is good guidance in that issue that might be reusable here

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Jun 2, 2024
@ExperimentsInHonesty
Copy link
Member

@roslynwythe It looks like you already made all these issues, so can I close this ER?

@ino-iosdev ino-iosdev mentioned this issue Jun 5, 2024
Merged
@roslynwythe
Copy link
Member Author

@roslynwythe This ER needs a reference to the Slack issue where this is being done, since there is good guidance in that issue that might be reusable here

Done

@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jun 13, 2024
This was referenced Sep 2, 2024
Open
Open
@roslynwythe roslynwythe mentioned this issue Nov 18, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roslynwythe roslynwythe

Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request Feature: Refactor HTML Issue Making: Level 2 Make issue(s) from an ER or Epic role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
x. Technical debt
Development

No branches or pull requests
2 participants
@roslynwythe @ExperimentsInHonesty