Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is very heavy #73

Open
Phyks opened this issue Sep 27, 2015 · 5 comments
Open

App is very heavy #73

Phyks opened this issue Sep 27, 2015 · 5 comments
Assignees

Comments

@Phyks
Copy link
Member

Phyks commented Sep 27, 2015

App currently weights nearly 500ko. I think we could reduce it a bit.

@eliemichel
Copy link
Member

It's actually much worst:

$ du -h --exclude .git --exclude doc
104K   ./img/headers/icons
24K    ./img/headers/ui/organic
20K    ./img/headers/ui/dark
12K    ./img/headers/ui/overlay
92K    ./img/headers/ui
200K   ./img/headers
68K    ./img/icons
36K    ./img/leaflet
396K   ./img
104K   ./css
168K   ./fonts
372K   ./js
1,1M   .
  1. I think we will eventually be able to drop almost any image from img/leaflet as we redefined our owns.
  2. We need to figure out why img/heqders is so heavy.
  3. Some compressions of images might be worth it (especially SVGs)
  4. We can also minify CSS and JS.

@Phyks Phyks self-assigned this Sep 30, 2015
@Phyks
Copy link
Member Author

Phyks commented Oct 4, 2015

Plus we should distinguish between our js and vendor js, to make the app more readable.

@eliemichel
Copy link
Member

I agree, and same for CSS.

@eliemichel
Copy link
Member

To be confirmed, but it seems that those stylesheets are not used:

  • css/lib/leaflet-routing-machine.css
  • css/lib/leaflet.touring.icons.css
  • css/lib/leaflet.touring.icons.svg

PS: @Phyks c663cc1 moves vendor code into lib directories in js/ and css/.

@Phyks Phyks added the long-term label Oct 6, 2015
@Phyks
Copy link
Member Author

Phyks commented Oct 13, 2015

Additionally, we should write a build script to minify js and css, but also translations. All of the translations should be compiled in a single ini file (actual l10n/locales.ini).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants