Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update event not sent correctly #108

Open
Phyks opened this issue Dec 21, 2015 · 1 comment
Open

Update event not sent correctly #108

Phyks opened this issue Dec 21, 2015 · 1 comment
Labels
bug

Comments

@Phyks
Copy link
Member

Phyks commented Dec 21, 2015

"update" event firing is buggy in Storage/StationStorage.js:79. I disabled it at the moment, not sure about the correct way to fix it. Seems that it is failing due to the fact that at this point, no callback have been defined for the "update" event in the rest of the code.

@eliemichel could you have a look at it?
@Phyks
Copy link
Member Author

Phyks commented Dec 21, 2015

Not sure why it appeared suddenly though.

I have the same issue with an event fired in starred view, but as it is not a real blocker, I let it go for the moment.

EDIT: Double checked and I have the same error a few commits ago, with your latest commit, although I did not notice it before.

@Phyks Phyks added the bug label Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Phyks