Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making separate files for css and javascript and linking them to index.html file #47

Open
Susmita-Dey opened this issue Oct 4, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Susmita-Dey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
CSS and JavaScript are written in the same file which is not a good way while developing a website.

Describe the solution you'd like
I want to make separate files for them and link them to the index.html file.

Describe alternatives you've considered
None

Additional context
Kindly assign it to me as part of hacktoberfest and web dev team of Hack4Bengal 2.0

@imanishbarnwal
Copy link
Member

Sure @Susmita-Dey we will definitely consider this. You can start working on this. Just make sure things are working as you want :P

@imanishbarnwal
Copy link
Member

Hi @Susmita-Dey few unwanted changes happened after the last PR could you please fix those?

  • First, the homepage buttons are shifted more to right. Kindly keep it on the left side.
  • Second, in the footer Address and email became a mess due to merge conflicts I guess. Kindly look into those ASAP.
    Attaching screenshots for reference.

image

image

@Susmita-Dey
Copy link
Contributor Author

@imanishbarnwal Okay I'm fixing them in a new PR

@Susmita-Dey
Copy link
Contributor Author

Kindly confirm if other changes are required or not

@Susmita-Dey
Copy link
Contributor Author

Fixed by #67

@imanishbarnwal
Copy link
Member

#30 is also removed I guess :)

@Susmita-Dey
Copy link
Contributor Author

@imanishbarnwal I didn't. Code is same as it's in that PR. Don't know what's the bug.

@imanishbarnwal
Copy link
Member

Okay will check. I just wanted to know if you're interested to be in Hack4Bengal Web Team just book a slot for yourself will talk about this further. Thank You!!

@Susmita-Dey
Copy link
Contributor Author

Okay will check. I just wanted to know if you're interested to be in Hack4Bengal Web Team just book a slot for yourself will talk about this further. Thank You!!

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants