Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore typography / punctuation (apostrophes, quotes, …) #83

Open
ya-d opened this issue Mar 15, 2021 · 5 comments
Open

Ignore typography / punctuation (apostrophes, quotes, …) #83

ya-d opened this issue Mar 15, 2021 · 5 comments

Comments

@ya-d
Copy link

ya-d commented Mar 15, 2021

It would be great to have an option to ignore typography. Could be implanted as a pool of unicode characters which are treated as the same character.

A common use case are apostrophes were don’t and don't are treated as separate answers. Same for straight and curly quotes and similar punctuation. There are several reports at the feedback section.

Related: #61. Thanks for considering!

@DegrangeM
Copy link

This is easy to add.

So ' = = and "= = ?

Should ' = " ?

Also should . = , → this might be very nice for maths in country where decimal use ,

Also should ' = (empty) ?

@dodsoner
Copy link

dodsoner commented Nov 8, 2021

I wanted to add that this issue is breaking key content, as in this example of fill in the blank content for English language learners (specifically, the answers that require don't or doesn't).

One big driver of this is that iPhones now insert the curly quotes by default, unless users have turned off those features. So, this typography bug affects a huge number of user devices.

@otacke
Copy link
Contributor

otacke commented Nov 8, 2021

A fix for this issue has been released just a couple of days after this issue was opened. It's in since version 1.12.11 of Fill in the Blanks. You might want to check what version you are running.

I just checked on iOS 14.7 and left single quotation marks and right single quotation marks that the iOS keyboard might emit are converted to apostrophes within blanks nicely. If it's not working on your end, I suggest that you provide more information - ideally on the H5P forum which is the central hub for reporting issues.

@dodsoner
Copy link

dodsoner commented Nov 8, 2021

Thank you, @otacke . Should this issue get closed out?

I'm indeed running an older version, and have updated. I'm still trying to make sure I've cleared out the caches, but the error is still happening. I'll give it a few more tests over time and make sure everything is pulling from the 1.12.11 version, and will head to the forum with any other issues.

And thanks for checking on your iOS device. I think what you wrote means that when you type something like doesn't, the iOS keyboard is now converting to the vertical tick, or '. If so, that's great. Thank you.

@otacke
Copy link
Contributor

otacke commented Nov 8, 2021

@dodsoner Yes, I assume someone from the H5P core team could close this issue. And yup, that's what I technically meant: The left single quotation marks () and right single quotation marks () (what you call curly quotes) are not used by iOS if a text input field has the attribute spellcheck set to false.

The code was added in 69ab18d#diff-872197d92b619c4a344ec34c1654df7874cb5c6bb7ad355bc42e81d721aa0535 and as you can see it has been around since v1.12.11. The latest releases version is v1.12.15 with 1.13.0 coming up next. Make sure to upgrade existing content if you've been running v1.11.x or earlier, otherwise you will only notice an effect for newly created content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants