Fixes #5738 #5740
Open
Fixes #5738 #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hutch3232
requested review from
mn-mikke,
krasinski,
wendycwong,
tomasfryda,
valenad1,
maurever and
syzonyuliia
as code owners
|
As of yesterday, python 3.8 is now end of life. If this project wants to be consistent with that, I could revise this PR to drop support for 3.8 and update this code to use the new function instead of the deprecated version. Would that be preferred? |
|
We currently support python 3.6 and above. |
|
Sounds good, I'll leave it as is unless you suggest otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid requiring
setuptoolsat runtime. Usingimportlibfrom the python standard library.importlib.resources.pathis actually deprecated:https://docs.python.org/3.12/library/importlib.resources.html#importlib.resources.path
however, the replacement was new in python 3.9. Can switch to the new
filesfunction once support is dropped for python < 3.9.