Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for response headers #422

Open
EyePulp opened this issue Jan 25, 2024 · 0 comments
Open

Adding support for response headers #422

EyePulp opened this issue Jan 25, 2024 · 0 comments

Comments

@EyePulp
Copy link

EyePulp commented Jan 25, 2024

We use imaginary upstream from an nginx cache, and would like for nginx to receive the cache-control response header from the http sources that imaginary is pulling from. In our case S3 and Google Cloud Storage, where we can set the cache-control value when the image is stored there.

It appears currently that imaginary just returns the image buffer / body content from the http.Response, and doesn't pass through the response headers.

We don't want to use -http-cache-ttl as that doesn't accurately reflect the cache-control needs of the source images.

I'm working on a PR that works similarly to the -forward-headers argument, except for url response headers. The idea being that users can decide what headers if any they want passed back from a response, e.g.:

/bin/imaginary -enable-url-source -return-response-headers cache-control,etag

I'm new to Golang and may need some help, but I'll get a PR together. Please let me know if you have concerns or recommendations.

Thanks!

EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
… giving them precedence over cache-control
EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
EyePulp added a commit to mirusresearch/imaginary that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant