From 495a349ae548ea029dac8158841156cde25305ce Mon Sep 17 00:00:00 2001 From: Jojain <50221409+Jojain@users.noreply.github.com> Date: Sun, 3 Nov 2024 22:54:11 +0100 Subject: [PATCH 1/2] Added better explanations of what are the points lists --- src/build123d/topology.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/build123d/topology.py b/src/build123d/topology.py index e20994dd..7dfe797f 100644 --- a/src/build123d/topology.py +++ b/src/build123d/topology.py @@ -6093,9 +6093,12 @@ def make_surface_from_array_of_points( """make_surface_from_array_of_points Approximate a spline surface through the provided 2d array of points. + The first list correspond to points on the vertical direction in the parameter space of the face. + The second list correspond to points on the horizontal direction in the parameter space of the face. + The 2 lists are UV points of the parameter space of the face. Args: - points (list[list[VectorLike]]): a 2D list of points + points (list[list[VectorLike]]): a 2D list of points, first list is V parameters second is U parameters. tol (float, optional): tolerance of the algorithm. Defaults to 1e-2. smoothing (Tuple[float, float, float], optional): optional tuple of 3 weights use for variational smoothing. Defaults to None. From 82af5847ebc9698a335c11a430d6dbd6b5a21e92 Mon Sep 17 00:00:00 2001 From: Jojain <50221409+Jojain@users.noreply.github.com> Date: Sun, 3 Nov 2024 23:02:04 +0100 Subject: [PATCH 2/2] talk about dimension not lists --- src/build123d/topology.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/build123d/topology.py b/src/build123d/topology.py index 7dfe797f..b65d82ae 100644 --- a/src/build123d/topology.py +++ b/src/build123d/topology.py @@ -6093,12 +6093,12 @@ def make_surface_from_array_of_points( """make_surface_from_array_of_points Approximate a spline surface through the provided 2d array of points. - The first list correspond to points on the vertical direction in the parameter space of the face. - The second list correspond to points on the horizontal direction in the parameter space of the face. - The 2 lists are UV points of the parameter space of the face. + The first dimension correspond to points on the vertical direction in the parameter space of the face. + The second dimension correspond to points on the horizontal direction in the parameter space of the face. + The 2 dimensions are U,V dimensions of the parameter space of the face. Args: - points (list[list[VectorLike]]): a 2D list of points, first list is V parameters second is U parameters. + points (list[list[VectorLike]]): a 2D list of points, first dimension is V parameters second is U parameters. tol (float, optional): tolerance of the algorithm. Defaults to 1e-2. smoothing (Tuple[float, float, float], optional): optional tuple of 3 weights use for variational smoothing. Defaults to None.