Update docs for v5.0 #2764
Assignees
Labels
Comments
|
A couple things I noticed during skimming:
|
|
Encoding option added: https://github.com/gulpjs/gulp/blob/master/docs/api/src.md#options |
|
"Explaining Globs" docs have been updated and a section added with an example for ordered globs using ordered-read-stream: https://github.com/gulpjs/gulp/blob/master/docs/getting-started/6-explaining-globs.md#ordered-globs |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this issue
May 31, 2024
This is a major version bump, and the changelog at https://github.com/gulpjs/gulp/releases/tag/v5.0.0 indicates one breaking change that impacts us, namely that streams are now by default interpreted/transformed to UTF-8 encoding. This breaks `gulp.src` calls that work on binary files such as images or CMaps, but is fortunately easy to fix for us by disabling re-encoding for all `gulp.src` calls (see gulpjs/gulp#2764 (comment) for more information). This restores the previous behavior of copying the files as-is without Gulp performing any transformations to it, which is what we want because Gulp is only used for bundling and we make sure that the source files have the right encoding.
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this issue
May 31, 2024
This is a major version bump, and the changelog at https://github.com/gulpjs/gulp/releases/tag/v5.0.0 indicates one breaking change that impacts us, namely that streams are now by default interpreted/transformed to UTF-8 encoding. This breaks `gulp.src` calls that work on binary files such as images or CMaps, but is fortunately easy to fix for us by disabling re-encoding for all `gulp.src` calls (see gulpjs/gulp#2764 (comment) for more information). This restores the previous behavior of copying the files as-is without Gulp performing any transformations to it, which is what we want because Gulp is only used for bundling and we make sure that the source files have the right encoding.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The markdown docs have been updated and redeployed to the website so I'm going to close this. As the major v4 release didn't contain a migration guide, we're not considering it required for v5 either. If anyone from the community wants to contribute further docs, like a migration guide, we're happy to review PRs! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We need to update the docs (and publish to website) for the v5 release.
The text was updated successfully, but these errors were encountered: