Toot a limited number of old toots when first creating an account for a feed. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of ignoring all existing feed items, toots a small number of feed items so that the activity stream does not start out completely empty.
If I understand the code correctly, the last updated time will be the year 1900 for accounts that have just been created and before its feed is updated, so the old feed items will be included during
updateAccountPostson account creation.I am assuming that the reason old feed items were not tooted was to prevent something like a thousand toots from being sent at the same time for a large feed. So if we are going to toot the most recent feed item, why not a bit more so it feels even less empty? Let me know if my understanding is wrong so I can update the comments and restrict the number to one.
A few parameters are now only ever true for some functions, so remove them to simplify things.
Resolves #41.