-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing dropdown menu option text #7
Comments
I'm assuming you mean the "Hierarchical Deterministic Wallet" page? The main reason to distinguish between BIP44/49/84 is because the encoding of the HD root node key is different for each of them: So I feel it's correct to use those different options. Or what exactly do you mean? |
I meant the "aezeed Cipher Seed Scheme" page, probably the "Hierarchical Deterministic Wallet" page is the same. I think it's probably not correct to use terms like BIP44/49/84 here because these three standards not only define the encoding (and the script/address type implied), but also define the derivation path, while the HD root node key obviously does not contain any derivation path. The xprv/yprv/zprv provided here encodes exactly the same key (the root node key), while a tool with full BIP44/49/84 support (like Ian Coleman's BIP39 tool) provides account extended pub/priv keys (as well as HD root node key, but it's provided in different position), rather than the root node key only. |
Also, yprv/zprv will probably obsolete in the future since https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md can handle both derivation path and address(script) type in a simple, clear, better way. |
Several dropdown menu options are provided for "HD node root key base58". However I think description text like "BTC (Bitcoin, legacy, BIP32/44)" "BTC (Bitcoin, SegWit, BIP49)" "BTC (Bitcoin, Native SegWit, BIP84)" might be confusing, because BIP44/49/84 defined their standard derivation paths respectively.
The text was updated successfully, but these errors were encountered: