Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing dropdown menu option text #7

Open
andronoob opened this issue Sep 1, 2020 · 3 comments
Open

Confusing dropdown menu option text #7

andronoob opened this issue Sep 1, 2020 · 3 comments

Comments

@andronoob
Copy link

Several dropdown menu options are provided for "HD node root key base58". However I think description text like "BTC (Bitcoin, legacy, BIP32/44)" "BTC (Bitcoin, SegWit, BIP49)" "BTC (Bitcoin, Native SegWit, BIP84)" might be confusing, because BIP44/49/84 defined their standard derivation paths respectively.

@guggero
Copy link
Owner

guggero commented Sep 1, 2020

I'm assuming you mean the "Hierarchical Deterministic Wallet" page?

The main reason to distinguish between BIP44/49/84 is because the encoding of the HD root node key is different for each of them:
Example mnemonic: merry immune feel luggage taste method six valid during zone fossil club
BIP44: xprv9s21ZrQH143K3T7oqJvzr7Gc6ckQKkh7ZY9QuTz71BfAfyxxtcyGXkdDXvax8gC57PPMUPjZZ8o5TUJMqEpbFSGr3jcg1F6s9oYdRAC3GB6
BIP49: yprvABrGsX5C9jantkJvffid4CN7GatrGNgcUefdgrszPC33j5nC9H8q9pHMZ8YY8aqzX2WADsL81o9dLkuvYwEc3fxSv5K6b9vMRXcGomm1ruo
BIP84: zprvAWgYBBk7JR8Gk3W3W2WFGHTcSZ3JCzg7PmBrUFmsmCQvnBbRPwJPmswVaLW88VVuvfcxyLvgUTWBE3XVGdecque3nR1XB4jqhFfvCM9jhTT

So I feel it's correct to use those different options. Or what exactly do you mean?

@andronoob
Copy link
Author

andronoob commented Sep 3, 2020

I meant the "aezeed Cipher Seed Scheme" page, probably the "Hierarchical Deterministic Wallet" page is the same.

I think it's probably not correct to use terms like BIP44/49/84 here because these three standards not only define the encoding (and the script/address type implied), but also define the derivation path, while the HD root node key obviously does not contain any derivation path. The xprv/yprv/zprv provided here encodes exactly the same key (the root node key), while a tool with full BIP44/49/84 support (like Ian Coleman's BIP39 tool) provides account extended pub/priv keys (as well as HD root node key, but it's provided in different position), rather than the root node key only.

@andronoob
Copy link
Author

Also, yprv/zprv will probably obsolete in the future since https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md can handle both derivation path and address(script) type in a simple, clear, better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants