Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Custom text position #205

Open
vtkhatri opened this issue May 6, 2020 · 3 comments
Open

Feature Request: Custom text position #205

vtkhatri opened this issue May 6, 2020 · 3 comments

Comments

@vtkhatri
Copy link

vtkhatri commented May 6, 2020

General information

Feature request

  • App version: any
  • System: any

Description

Allow user to choose the position of text on image if they want to.

@magnus-ISU
Copy link

I feel like this is one of the most important things in a meme creator. I'll take a look at it later, but also want to add that the app is not very useful without this so I'm disappointed it isn't already implemented.

@fridewald
Copy link

So if I see this correctly there is only one Textview in the MemeCreateActivity which is fixed at the top. So if we want to get custom text position, we maybe need 2 Textviews that can be dragged and scaled, this would mean to rewrite a lot of the logic right now.

It might also be possible to make it with the current setup, but I'm not sure how one would then decide which text should be used. One could add some buttons to choose which text should be edited, and then only this text will get dragged around. In the case of dragging this would mean another click and you might press the wrong button.

So I think the proper way is to have multiple textviews in the end.

@gsantner
Copy link
Owner

Wrong, you have to differentiate between drawn overlay and the input.

For text input there is only one textield field, which is used for any input to any overlay field.

Currently there are two such drawn overlay fields, top & bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants