Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CI Cleanup #1474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: CI Cleanup #1474

wants to merge 1 commit into from

Conversation

yhakbar
Copy link
Contributor

@yhakbar yhakbar commented Nov 19, 2024 •
edited
Loading

Description

Cleaning up CI so that we regularly test Azure correctly.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@yhakbar yhakbar marked this pull request as ready for review November 19, 2024 19:49
@yhakbar yhakbar requested a review from denis256 as a code owner November 19, 2024 19:49
@yhakbar
Copy link
Contributor Author

yhakbar commented Nov 19, 2024

The tests here are running correctly in CI now, even if they aren't passing. Should be good to merge so that we can have Azure tests evaluated in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yhakbar