Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chart Hooks #122

Open
melhin opened this issue Jan 12, 2022 · 5 comments
Open

Add support for Chart Hooks #122

melhin opened this issue Jan 12, 2022 · 5 comments
Labels
needs design We need to flesh out the design before we can resolve the issue p:backlog

Comments

@melhin
Copy link

melhin commented Jan 12, 2022

Is there a way to define cronjobs in this setup.
also we have some pre-install preupgrade jobs that we would like to run is there a mechanism for that ?

Are these features in pipeline or they already available and Im not able to find them ?

@autero1
Copy link
Contributor

autero1 commented Jan 12, 2022

Is there a way to define cronjobs in this setup.

The k8s-service chart's main function is deploying application containers with a Deployment resource. I think a CronJob would call for a separate chart. We don't currently have plans for that.

pre-install preupgrade jobs that we would like to run

I assume you're referring to Chart Hooks. We don't currently support those. While it's a valid feature request, we probably have to triage this first. There are multiple things to consider:

  • Which resources types would we support (Job, Pod, ConfigMap, Secret)?
  • Would we limit the amount of resources to one or allow multiple?

@autero1 autero1 added p:needs triage Needs to be processed by maintainer and issue type / priority added question Further information is requested labels Jan 12, 2022
@melhin
Copy link
Author

melhin commented Jan 13, 2022

Thank you for the reply @autero1 👍🏾 .

Just out of curiosity is there a particular reason for not supporting CronJob charts in k8s ?

@autero1
Copy link
Contributor

autero1 commented Jan 13, 2022

I would say that time is the biggest limiting factor 😃 . We have an issue for supporting Job resources and haven't really had time to prioritize working on it.

@melhin
Copy link
Author

melhin commented Jan 14, 2022

Thank you for the reply @autero1 . I completely understand

@rhoboat rhoboat added p:backlog and removed p:needs triage Needs to be processed by maintainer and issue type / priority added labels Apr 12, 2022
@rhoboat rhoboat changed the title [Question] CronJobs, Pre Install , Post Install Hooks Add support for Chart Hooks Apr 12, 2022
@rhoboat rhoboat added needs design We need to flesh out the design before we can resolve the issue and removed question Further information is requested labels Apr 12, 2022
@rhoboat
Copy link
Contributor

rhoboat commented Apr 12, 2022

Converting this issue to track the feature request for Chart Hooks support. We'll track CronJob support in #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design We need to flesh out the design before we can resolve the issue p:backlog
Projects
None yet
Development

No branches or pull requests

3 participants