Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with latest v26 Protocol Buffers (GeneratedMessageV3 removal) #593

Closed
dennisameling opened this issue Apr 3, 2024 · 6 comments

Comments

@dennisameling
Copy link

Protocol Buffers v26.0 was released three weeks ago.

One of the breaking changes is this one:

[Java] The base class for generated messages will be GeneratedMessage, not GeneratedMessageV3.

This library doesn't seem to be compatible anymore now. For example, this PR is broken: #588

    e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
        class io.grpc.examples.routeguide.Feature, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.BaaReply.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.animals.BarkReply.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.animals.OinkReply.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.helloworld.HelloReply.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.helloworld.HelloRequest.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.routeguide.FeatureDatabase.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.routeguide.Feature.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.routeguide.Point.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.routeguide.Rectangle.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.routeguide.RouteNote.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.routeguide.RouteSummary.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.animals.BaaReply, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.BaaRequest, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.BaaRequest.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.animals.BarkReply, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.BarkRequest, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.BarkRequest.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.animals.OinkReply, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.OinkRequest, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.animals.OinkRequest.Builder, unresolved supertypes: Builder<Builder>
        class io.grpc.examples.helloworld.HelloReply, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.helloworld.HelloRequest, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.routeguide.FeatureDatabase, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.routeguide.Point, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.routeguide.Rectangle, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.routeguide.RouteNote, unresolved supertypes: GeneratedMessageV3
        class io.grpc.examples.routeguide.RouteSummary, unresolved supertypes: GeneratedMessageV3

Is there anything we can do to help make it compatible? Thanks!

@dennisameling
Copy link
Author

dennisameling commented Apr 5, 2024

Turns out there have been 75 commits to the master branch since the latest 1.4.1 release on December 14th, 2023. One of them is this one, which might (at least partially) fix these version mismatches.

@jamesward would you be able to release a new version with the latest changes from the master branch? We'd like to try and see if that resolves the issues for us. Thanks! 😊

Related issue: grpc/grpc-java#11015

@jamesward
Copy link
Collaborator

Hi @dennisameling, unfortunately I'm no longer working at Google so someone else will need to roll the release. Sorry!

@westito
Copy link

westito commented Apr 28, 2024

There is somebody at Google that can release a new version?

@jamesward
Copy link
Collaborator

@lowasser should be able to. Instructions are at:
https://github.com/grpc/grpc-kotlin/blob/master/BUILDING.md#releasing

@jasonab
Copy link

jasonab commented Jun 26, 2024

this problem appears to have been fixed on the Java side

@dennisameling
Copy link
Author

This indeed seems to be an issue with grpc-java (related to the Protobuf upgrade) and not this particular library. A partial fix is already in place, with more fixes coming soon. I'm going to close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants