Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttemptMetadataKey = "x-retry-attempt" in retry StreamClientInterceptor #731

Open
Boklazhenko opened this issue Nov 21, 2024 · 3 comments
Open

Comments

@Boklazhenko
Copy link
Contributor

Hi, Is it possible add AttemptMetadataKey = "x-retry-attempt"
https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/interceptors/retry/retry.go#L22

in StreamClientInterceptor ?

exactly the same way it works in UnaryClientInterceptor

thank you

@johanbrandhorst
Copy link
Collaborator

Seems like it might be possible to just add it to the context of the streaming call. Would you like to contribute this fix?

@Boklazhenko
Copy link
Contributor Author

yes, i can try that later

@Boklazhenko
Copy link
Contributor Author

Boklazhenko commented Nov 27, 2024

#733
MR

I have lint error,
Снимок экрана 2024-11-27 в 18 08 14
something about copyright, readme, but I didn't touch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants