-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Prevent white lines on (almost) white background #561
Comments
Line colors are coming from the data source which should use official colors. |
Hi @grote! Thanks for explaining. Do you mean 'should' as in: In that case I guess the question would be: how would one find a balance between using official colours and keeping them visible on a white background? |
I guess some data sources use official colors and others don't. I can't travel and investigate this everywhere. A solution could be to add a dark stroke color around the white lines when the user uses the light theme and a bright color when the user uses the dark theme and has dark line colors. Feel free to do a PR for the stroke solution. |
I implemented a fix for this in #948. In short, these are the things I changed to fix this issue:
Feel free to give your feedback about it :) |
I'm looking for feedback on the UI changes in #948, if someone is willing to try it out and review the changes it would be great :) I don't feel comfortable merging a big UI change without feedback :) |
@Altonss I would have loved to test this, but sadly, since opening this issue, Transportr has stopped working in the Netherlands. |
Hi there. I hope to contribute to the project with some feedback on the UI: I have a hard time seeing the white connection lines for trains. I'm unfamiliar with the method used for the colouring of the connections, but it does not appear to prevent colours with high similarity to the application's background, which is also (almost) white. Since trains are always white for me (NL) this is a recurring challenge.
The text was updated successfully, but these errors were encountered: