Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Prevent white lines on (almost) white background #561

Open
HansCronau opened this issue Dec 17, 2018 · 6 comments · May be fixed by #948
Open

[UX] Prevent white lines on (almost) white background #561

HansCronau opened this issue Dec 17, 2018 · 6 comments · May be fixed by #948
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. enhancement 🏗️ A functional improvement.
Milestone

Comments

@HansCronau
Copy link

HansCronau commented Dec 17, 2018

Hi there. I hope to contribute to the project with some feedback on the UI: I have a hard time seeing the white connection lines for trains. I'm unfamiliar with the method used for the colouring of the connections, but it does not appear to prevent colours with high similarity to the application's background, which is also (almost) white. Since trains are always white for me (NL) this is a recurring challenge.

@grote
Copy link
Owner

grote commented Dec 18, 2018

Line colors are coming from the data source which should use official colors.

@grote grote added the enhancement 🏗️ A functional improvement. label Dec 18, 2018
@HansCronau
Copy link
Author

Hi @grote! Thanks for explaining.

Do you mean 'should' as in:
"The source should use official colours (though maybe it doesn't)"?

In that case I guess the question would be: how would one find a balance between using official colours and keeping them visible on a white background?

@grote
Copy link
Owner

grote commented Dec 18, 2018

I guess some data sources use official colors and others don't. I can't travel and investigate this everywhere. A solution could be to add a dark stroke color around the white lines when the user uses the light theme and a bright color when the user uses the dark theme and has dark line colors.

Feel free to do a PR for the stroke solution.

@ialokim ialokim added the beginner job 🔰 This is a relatively easy task suitable for new contributors. label Sep 6, 2020
@ialokim ialokim added this to the 2.2 milestone Sep 8, 2020
@Altonss Altonss linked a pull request May 25, 2024 that will close this issue
@Altonss
Copy link
Collaborator

Altonss commented May 25, 2024

I implemented a fix for this in #948. In short, these are the things I changed to fix this issue:

  • Invert line background color if contrast isn't high enough. (This might lead to some mismatch with some official colors, but it's not that commom, and I'd say it is a good compromise :) )
  • Don't use the foreground color provided by line, simple choose the best between white and black for best readability :)

Feel free to give your feedback about it :)

@Altonss Altonss linked a pull request Nov 1, 2024 that will close this issue
@Altonss
Copy link
Collaborator

Altonss commented Nov 4, 2024

I'm looking for feedback on the UI changes in #948, if someone is willing to try it out and review the changes it would be great :) I don't feel comfortable merging a big UI change without feedback :)

@Altonss Altonss modified the milestones: 2.2, 2.2.2 Nov 7, 2024
@Altonss Altonss modified the milestones: 2.2.2, 2.2.3 Dec 1, 2024
@HansCronau
Copy link
Author

@Altonss I would have loved to test this, but sadly, since opening this issue, Transportr has stopped working in the Netherlands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. enhancement 🏗️ A functional improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants