You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
It was just a typo that was breaking clabot, so fixed it directly. Sorry to have caught you off guard.
If it's not ok to do it like this, don't hesitate to tell me. I'm sorry if it is or felt wrong.
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be ok to just fix the .clabot file quickly (as it was done directly on mastera3b2e3f). I wouldn't have done it on any other file. If you want we could set up more strict & clear rules.
The reason will be displayed to describe this comment to others. Learn more.
Ah, welp, I guess I'm learning the process here. I only saw some repo owners push to the main trunk but haven't seen contributors do this for awhile. good to know
7fc2204There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you directly push to
master?sort of caught me off-guard here - shouldn't we follow the code review process?
7fc2204There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was just a typo that was breaking clabot, so fixed it directly. Sorry to have caught you off guard.
If it's not ok to do it like this, don't hesitate to tell me. I'm sorry if it is or felt wrong.
7fc2204There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be ok to just fix the .clabot file quickly (as it was done directly on
mastera3b2e3f). I wouldn't have done it on any other file. If you want we could set up more strict & clear rules.7fc2204There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, welp, I guess I'm learning the process here. I only saw some repo owners push to the main trunk but haven't seen contributors do this for awhile. good to know
7fc2204There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's maybe try to avoid pushing to
maindirectly.