Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conventions #220

Closed
wants to merge 4 commits into from
Closed

Naming conventions #220

wants to merge 4 commits into from

Conversation

JanLukasGithub
Copy link

@JanLukasGithub JanLukasGithub commented Jun 2, 2022

Renames all variables, functions and types that had names not conforming to Go naming conventions

This will break the API and should only be pulled for the next major version

Fixes #181 when it's time for it

Linting should be added to the github workflow when this is pulled, as this fixes all current linting errors

@nvthongswansea nvthongswansea added the breaking-change A change that needs a major version bump label Jun 2, 2022
@nvthongswansea
Copy link
Member

@JanLukasGithub Thank you for this PR. I will label this for the next major release.

@nvthongswansea nvthongswansea added this to the v4 milestone Jun 2, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change that needs a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make exported types and functions adhere Go naming conventions
2 participants