Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GSTime a type definition #144

Open
bkircher opened this issue Sep 3, 2020 · 0 comments
Open

Make GSTime a type definition #144

bkircher opened this issue Sep 3, 2020 · 0 comments
Labels
breaking-change A change that needs a major version bump
Milestone
v4

Comments

@bkircher
Copy link
Contributor

bkircher commented Sep 3, 2020

Don't use embedded struct for GSTime. Right now it is

type GSTime struct {
  time.Time
}

Make it

type GSTime time.Time

so that we can use type conversion.
@bkircher bkircher added this to the v4 milestone Sep 3, 2020
@bkircher bkircher added the breaking-change A change that needs a major version bump label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change A change that needs a major version bump
Projects
None yet
Milestone
v4
Development

No branches or pull requests
1 participant
@bkircher