Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 9.1 config parsing: wal_buffers configuration #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schmiddy
Copy link
Contributor

If you try to parse a 9.1 config file, you will blow up like this:

Traceback (most recent call last):
  File "./pgtune", line 698, in <module>
    sys.exit(main(sys.argv))
  File "./pgtune", line 687, in main
    wizard_tune(config, options, settings)
  File "./pgtune", line 593, in wizard_tune
    if settings.memory_unit(key):
  File "./pgtune", line 402, in memory_unit
    return (self.param_to_dict[setting])['memory_unit']
KeyError: 'wal_buffers'

Since the pg_settings-9.1-64 file was missing a line about wal_buffers. Add that missing line, and solve the TODO noted about not needing to figure out wal_buffers at all. Now, the output postgresql.conf should just leave wal_buffers as it was, i.e. left at the auto-configured -1 by default.

Josh Kupershmidt added 2 commits October 28, 2015 19:02
@schmiddy schmiddy changed the title wal_buffers for 9.1 Fix 9.1 config parsing: wal_buffers configuration Oct 28, 2015
@scottcc
Copy link

scottcc commented Oct 29, 2015

👍

andreif added a commit to andreif/pgtune that referenced this pull request Apr 7, 2016
@andreif
Copy link

andreif commented Apr 7, 2016

andreif added a commit to andreif/pgtune that referenced this pull request Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants